Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix netdns success rate err #228

Merged
merged 1 commit into from
Oct 7, 2023
Merged

fix netdns success rate err #228

merged 1 commit into from
Oct 7, 2023

Conversation

ii2day
Copy link
Collaborator

@ii2day ii2day commented Sep 26, 2023

fix #227
计算 成功率时,分母填写错误导致计算结果永远为 1

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #228 (57ab077) into main (67c6bf7) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   38.94%   38.94%           
=======================================
  Files           8        8           
  Lines         529      529           
=======================================
  Hits          206      206           
  Misses        318      318           
  Partials        5        5           
Flag Coverage Δ
unittests 38.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@weizhoublue
Copy link
Collaborator

没有用例闭环这个 成功率问题 么
比如在 server 端 获取的成功率 和 kdoctor 比较

@ii2day
Copy link
Collaborator Author

ii2day commented Sep 27, 2023

没有用例闭环这个 成功率问题 么 比如在 server 端 获取的成功率 和 kdoctor 比较

目前没有成功率这方面的用例判断。只判断了总体任务成功失败。

@weizhoublue
Copy link
Collaborator

weizhoublue commented Sep 27, 2023

没有用例闭环这个 成功率问题 么 比如在 server 端 获取的成功率 和 kdoctor 比较

目前没有成功率这方面的用例判断。只判断了总体任务成功失败。

必须要有用例 闭环 PR 的修改,不接受 不能独立闭环 的 PR

Signed-off-by: ii2day <ji.li@daocloud.io>
@ii2day
Copy link
Collaborator Author

ii2day commented Sep 28, 2023

没有用例闭环这个 成功率问题 么 比如在 server 端 获取的成功率 和 kdoctor 比较

目前没有成功率这方面的用例判断。只判断了总体任务成功失败。

必须要有用例 闭环 PR 的修改,不接受 不能独立闭环 的 PR

用例已添加

@weizhoublue weizhoublue merged commit 1ab7ded into main Oct 7, 2023
22 checks passed
@weizhoublue weizhoublue deleted the pr/ii2day/netdns branch October 7, 2023 04:09
github-actions bot pushed a commit that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

software bug netdns success rate statistical error
2 participants