add e2e for http #31
Merged
add e2e for http #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 40.28% 40.28%
=======================================
Files 8 8
Lines 494 494
=======================================
Hits 199 199
Misses 291 291
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. |
ii2day
force-pushed
the
e2e
branch
6 times, most recently
from
11daec2
to
569389f
Compare
weizhoublue
reviewed
Jun 27, 2023
test/e2e/common/constants.go
Outdated
| MultusNamespace = "kube-system" | ||
| MultusCRName = "ptp" | ||
|
|
||
| KDoctorAgentNS = "kube-system" |
There was a problem hiding this comment.
不应该是 hardcode，而是 CI 变量传递
weizhoublue
reviewed
Jun 27, 2023
| testDS, e := frame.GetDaemonSet(common.KDoctorTestDSName, common.KDoctorAgentNS) | ||
| Expect(e).NotTo(HaveOccurred(), "get kdoctor test daemonset") | ||
|
|
||
| testPods, e := frame.GetDaemonSetPodList(testDS) |
ii2day
force-pushed
the
e2e
branch
5 times, most recently
from
e724314
to
4695610
Compare
ii2day
force-pushed
the
e2e
branch
7 times, most recently
from
282c757
to
ce5ca04
Compare
weizhoublue
reviewed
Jun 28, 2023
test/yaml/kdoctortoken.yaml
Outdated
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: kdoctor-test-token |
weizhoublue
reviewed
Jun 28, 2023
test/e2e/common/constants.go
Outdated
|
|
||
| const ( | ||
| ImageRegistry = "ghcr.io/kdoctor-io/kdoctor-agent" | ||
| PluginReportPath = "/apis/system.kdoctor.io/v1beta1/namespaces/default/pluginreports/" |
There was a problem hiding this comment.
避免 hardcode， 没有 import 来引用么
weizhoublue
reviewed
Jun 28, 2023
test/e2e/common/constants.go
Outdated
| import "os" | ||
|
|
||
| const ( | ||
| ImageRegistry = "ghcr.io/kdoctor-io/kdoctor-agent" |
There was a problem hiding this comment.
不能 hardcode，要工程化，否则不能本地跑
应该 外部 通过 helm 绚烂 获取出 agent 的 image
weizhoublue
reviewed
Jun 28, 2023
test/e2e/common/constants.go
Outdated
| PluginReportPath = "/apis/system.kdoctor.io/v1beta1/namespaces/default/pluginreports/" | ||
|
|
||
| KDoctorAgentDSName = "kdoctor-agent" | ||
| KdoctorTestTokenSecretName = "kdoctor-test-token" |
weizhoublue
reviewed
Jun 28, 2023
| Expect(e).NotTo(HaveOccurred()) | ||
|
|
||
| // test request body | ||
| bodyConfigMapName = "kdoctor-test-body-" + tools.RandomName() |
There was a problem hiding this comment.
每个用例 beforeeach 最好 建自己 的 namespace 和 测试服务，避免 it 之间 串扰
weizhoublue
reviewed
Jun 28, 2023
test/e2e/common/constants.go
Outdated
| KdoctroTestToken = "" | ||
| APISERVICEADDR = "" | ||
| TestNameSpace = "kube-system" | ||
| TestImageTag = "v0.1.0" |
There was a problem hiding this comment.
跟着 ci 的版本走，不能 hardcode
PROJECT_IMAGE_VERSION
There was a problem hiding this comment.
这些是从环境变量中获取的，只是给了一个默认值
ii2day
force-pushed
the
e2e
branch
10 times, most recently
from
edbb553
to
6fd2fca
Compare
weizhoublue
reviewed
Jul 12, 2023
| Expect(e).NotTo(HaveOccurred(), "wait appHttpHealth task finish") | ||
|
|
||
| // wait report gen | ||
| time.Sleep(time.Second * 20) |
weizhoublue
reviewed
Jul 12, 2023
| ) | ||
|
|
||
| const ( | ||
| PluginReportPath = "/apis/system.kdoctor.io/v1beta1/namespaces/default/kdoctorreports/" |
ii2day
force-pushed
the
e2e
branch
2 times, most recently
from
f776a89
to
ca7970d
Compare
weizhoublue
reviewed
Jul 12, 2023
| Expect(e).NotTo(HaveOccurred(), "wait test daemonSet and service ready") | ||
|
|
||
| // wait pod running | ||
| time.Sleep(time.Second * 20) |
There was a problem hiding this comment.
framework的waitdaemonset ready 这个函数这是等待 pod的状态，但是并不是 pod真正running ，这里等待一下 pod的业务可以访问
There was a problem hiding this comment.
pod有自身的 健康检测，那 应该是用一个 api 等待 pod ready 才是最优雅的做法 ？也不至于 20s 比 用例本身时间 还长
ii2day
force-pushed
the
e2e
branch
4 times, most recently
from
5b0d291
to
43cd4a8
Compare
weizhoublue
reviewed
Jul 14, 2023
test/e2e/common/tools.go
Outdated
|
|
||
| func CreateApplicationDaemonSetAndService(f *frame.Framework, key metav1.ObjectMeta, app, insecure bool) error { | ||
| ds := new(appsv1.DaemonSet) | ||
| svc := new(corev1.Service) |
ii2day
force-pushed
the
e2e
branch
5 times, most recently
from
cec1d8e
to
2191cac
Compare
Signed-off-by: ii2day <ji.li@daocloud.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.