Independent Module - MDF update for Passive modules #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junchao-Mellanox
requested changes
Dec 26, 2023
platform/mellanox/mlnx-platform-api/sonic_platform/modules_mgmt.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/modules_mgmt.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/modules_mgmt.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/modules_mgmt.py
Outdated
Show resolved
Hide resolved
…the case of flat memory modules that are not CMIS nor SFF
platform/mellanox/mlnx-platform-api/sonic_platform/modules_mgmt.py
Outdated
Show resolved
Hide resolved
platform/mellanox/mlnx-platform-api/sonic_platform/modules_mgmt.py
Outdated
Show resolved
Hide resolved
| logger.log_debug(f"check_module_type reading mci max frequency for port {port}") | ||
| read_mci = xcvr_api.xcvr_eeprom.read_raw(CMIS_MCI_EEPROM_OFFSET, 1) | ||
| logger.log_debug(f"check_module_type read mci max frequency {read_mci} for port {port}") | ||
| frequency = read_mci & CMIS_MCI_MASK |
There was a problem hiding this comment.
Will it generate 0 or 1? I understand this is existing code, should we open a bug to Doron or fix it by ourself here?
There was a problem hiding this comment.
I actually tried to run this on some python interpreter online:
CMIS_MCI_MASK = 0b00001100
read_mci = 0b10000000
frequency = read_mci & CMIS_MCI_MASK
print(frequency)
and looks like it does generate 0 or 1
There was a problem hiding this comment.
>>> read_mci = 0b10001000 # read mci is 1MHz
>>> frequency = read_mci & CMIS_MCI_MASK
>>> frequency
8
Junchao-Mellanox
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To extend the support of Independent Module to also include passive modules.
Work item tracking
How I did it
I Updated the Module Detection Flow logic to also label passive modules as Software Control
How to verify it
Verify passive modules are labeled as SW_CONTROL using the relevant sysfs, and verify all ports are up and have traffic.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)