Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix speed parsing when speed if not fetched from APPL_DB #14

Closed
wants to merge 1 commit into from

Conversation

keboliu
Copy link
Owner

@keboliu keboliu commented Apr 20, 2022

Signed-off-by: Kebo Liu kebol@nvidia.com

What I did

In PR sonic-net#2110 introduced an enhancement to support display port speed with different unit when it is RJ45 ports, however, it only covered the case that the speed was fetched from APPL_DB.
Recently there is a change to fetch the speed from STATE_DB in some cases, the same logic also needs to be applied in this case.

How I did it

  1. rename appl_db_port_speed_parse to a more generic name port_speed_parse
  2. call port_speed_parse when speed is fetched from STATE_DB

How to verify it

UT and test it on platform support RJ45 ports

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Kebo Liu <kebol@nvidia.com>
@keboliu keboliu requested a review from stephenxs April 20, 2022 11:24
@keboliu keboliu closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants