Helm 3 install failed

[jiayanguo]

When I am trying to install Keda in minikube via Helm3, it throws below error.

helm install keda kedacore/keda --namespace keda                                                                                  
manifest_sorter.go:175: info: skipping unknown hook: "crd-install"
manifest_sorter.go:175: info: skipping unknown hook: "crd-install"
NAME: keda
LAST DEPLOYED: Sun Nov 24 18:22:12 2019
NAMESPACE: keda
STATUS: deployed
REVISION: 1
TEST SUITE: None

[jeffhollan]

That looks good to me. The skipping is to be expected as it’s required for helm 2 but skipped for helm 3. When you check the ‘keda’ namespace do you see the keda operator running?

‘Kubectl get pods -n keda’

[jiayanguo]

Thanks @jeffhollan. Yes. I see the Kada namespace.

[tomkerkhove]

Can we improve this somehow so that it no longer comes up? It can be confusing for new people.

[anirudhgarg]

Yes I also saw this and was not sure if this meant that there was an error. It would be great if these messages do no show up.

[tomkerkhove]

@jeffhollan Would it be possible to get permission on chart repo to move this issue there?

[catirado]

Any news on that? The same problem here because the skipping unknown hook: "crd-install" throws an error in the CI and this makes the job fail.

I was trying to follow the proposed changes in #17, but I see that the related to this issue were removed because of the need for backward compatibility with Helm 2. Also in #20 that the issue of labels is resolved as well.

Any chance of getting it back?

Thank you so much

[tomkerkhove]

We are keeping Helm 2 support for now as we have a lot of customers still using it to date - #40

In the past it just gave a warning instead of an error which is odd. Is it specific to your CI or not?

[catirado]

I may not have expressed myself well, the task itself is not failing, but write records in the stderr. So if the task fails in the CI, it's probably related to the CI we use, Azure Devops.

In fact, you've given me a hint, and I've seen that it's a known problem in the Helm Deploy task
https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/deploy/helm-deploy?view=azure-devops#when-using-helm-3-if-systemdebug-is-set-to-true-and-helm-upgrade-is-the-command-being-used-the-pipeline-fails-even-though-the-upgrade-was-successful

We can "fix" this by including failOnStderr: false to ignore the logs printed to stderr as the docs suggest, so maybe no changes are needed.

Thank you Tom

[tomkerkhove]

Happy to help and sorry for the pain!

[channeladam]

If it isn't an actual error, it shouldn't be logged to stderr. Setting fail on stderr to false could hide other possible problems - this is not a safe workaround.

[tomkerkhove]

I fully agree @channeladam!

Given Helm just did their final Helm 2.x release, they published that it's no longer being updated and we have KEDA 2.0 coming up I think it's time to move on.

Thoughts on removing Helm 2.0 support and close this issue @jeffhollan @ahmelsayed @zroubalik @anirudhgarg ?

[tomkerkhove]

@tbickford Is it correct that you had a solution for this without removing 2.0 support?

[tomkerkhove]

Actually I think it's time to move off: https://twitter.com/technosophos/status/1306640949896912901

[tbickford]

@tomkerkhove Apologies - I have been on PTO. This PR #60 should allow for both Helm 2 and 3 compatibility

[tomkerkhove]

We're removing support for Helm v2.x being tracked in #81.

[tomkerkhove]

Fixed in https://github.com/kedacore/charts/releases/tag/v2.0.0