-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Helm chart to an OCI-compatible repo to support versioning #20
Comments
Concern with this would be that OCI support for helm repos appears to be opt-in and expiremental? https://helm.sh/docs/topics/registries/#enabling-oci-support |
But like the idea of having versioned outside of just git commits. Also do love how easy hosting a chart from a GitHub pages is (what we are doing today). Open to options though |
Actually looks like we are snapshotting versions of the chart for each release. We currently have 2 chart versions: 1.0.0 and 1.1.0 and soon will have a 1.2.0 |
It looks like you are right:
I've missed that part, sorry :/ I'd suggest to close it and keep as is then, ok? |
Helm v3 now fully supports OCI-based Helm charts. I was wondering whether this ticket could be reopened, and whether the KEDA Helm charts could (additionally) be pushed to some OCI registry. Use case: OCI-based Helm chart hosting greatly simplifies accessing a Helm chart from a CI/CD runner when there are corporate network restrictions, with OCI-registry mirrors (which do not properly support synchronizing upstream ChartMuseum-based charts). |
I'm happy to re-evaluate this - Any guidance or want to contribute this? Did they close on how to use it? Because I recall OCI was a pain in the past. (sorry for slow response btw) |
OCI with Helm used to be a PITA, but has become stable. The basic idea is that wherever you are pushing your Helm chart (I did not find the GHA-workflow), you also run |
Any news on this feature ? Thanks. |
I don't think we have objections, but open to contributions as long as it does not cause breaking changes |
I think the publishing process is manually, right? Or where is the code who creates new releases like this: Looks like @JorTurFer created it? |
It is manual indeed as we want to have things under control, not always ship a new one |
@tomkerkhove Do you have a script for that which we could extend? |
This is documented on https://github.com/kedacore/charts/blob/main/CONTRIBUTING.md#shipping-a-new-version. @JorTurFer /@zroubalik Any concerns for automating through GitHub Actions? My only requirement is that it gets triggered on GitHub Release by a human, not for every commit. |
We could trigger the release in the same way that we use for the code and probably it'll make our life easier xD
Is this something open to discussion? I think that we could improve our chart release process with automatic releases on commits if we update the process to ensure the same quality. There are other projects that generate the release notes automatically from changelog files which we could require. I mean, there are options to ship helm chart automatically with a good quality if that's your afraid |
Agree with @JorTurFer |
Any updates on that ? This could seriously help us setting up auto upgrades with flux cd , that heavily relying on OCI repos |
When we moved to this repo, we decided to move away from hosting our charts on
https://kedacore.azureedge.net/helm
overhttps://kedacore.github.io/charts
. (see helm/hub#181)Unfortunately, this means that we are losing our Helm chart versioning.
I'd suggest to publish our Helm chart to an OCI-compatible repo such as Azure Container Registry so that:
The text was updated successfully, but these errors were encountered: