Double scraping of apiserver metrics when using podMonitor

[mhowell24]

When the podMonitor is enabled for the metrics server it is double scraped. This is because the metrics server podMonitor is only deployed if prometheus.metricServer.enabled and prometheus.metricServer.podMonitor.enabled. But when prometheus.metricServer.enabled is true the metric server deployment spec has the scrape annotations added. If the podMonitor is enabled then the scrape annotations should be dropped to stop the double scraping.

Happy to put up a PR with a fix if you agree this is an issue.

Expected Behavior

• The metrics server metrics are only scraped by the podMonitor

Actual Behavior

• The metrics server metrics are scraped twice, once because of the podMonitor and once because of the scrape annotations

Steps to Reproduce the Problem

1. set prometheus.metricServer.enabled: true and prometheus.metricServer.podMonitor.enabled: true

Specifications

• KEDA Version: Please elaborate
• Platform & Version: Please elaborate
• Kubernetes Version: Please elaborate
• Scaler(s): Please elaborate

[tomkerkhove]

That's a fair ask! Would love to review your PR if you are still OK with it?

[mhowell24]

@tomkerkhove no problem have opened #279