Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove metrics server Prometheus scrape accotations if podMonitor is enabled #279

Merged
merged 1 commit into from
May 25, 2022
Merged

Remove metrics server Prometheus scrape accotations if podMonitor is enabled #279

merged 1 commit into from
May 25, 2022

Conversation

mhowell24
Copy link
Contributor

@mhowell24 mhowell24 commented May 24, 2022 •
edited
Loading

Remove metrics server Prometheus scrape accotations if podMonitor is enabled.

Signed-off-by: Max Howell maxhowell24@gmail.com

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes #277

@mhowell24 mhowell24 requested a review from a team as a code owner May 24, 2022 22:05
@mhowell24 mhowell24 mentioned this pull request May 24, 2022
Closed
tomkerkhove
tomkerkhove reviewed May 25, 2022
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you revert bumping the chart version please?

@mhowell24 mhowell24 force-pushed the feature/fix-metric-server-scrape-annotations branch from a50070a to 1e1f2eb Compare May 25, 2022 08:04
@mhowell24
Remove metrics server Prometheus scrape annotations if using podMonitor
3a76492 
Signed-off-by: Max Howell <maxhowell24@gmail.com>
@mhowell24 mhowell24 force-pushed the feature/fix-metric-server-scrape-annotations branch from 1e1f2eb to 3a76492 Compare May 25, 2022 08:12
@mhowell24
Copy link
Contributor Author

@tomkerkhove I have removed the chart patch bump and package, sorry thought I had to do that from the CONTRIBUTING.md

@tomkerkhove
Copy link
Member

@tomkerkhove I have removed the chart patch bump and package, sorry thought I had to do that from the CONTRIBUTING.md

That's more for just releasing a new version rather than for every PR, sorry for the confusion!

@tomkerkhove tomkerkhove merged commit 19e3194 into kedacore:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double scraping of apiserver metrics when using podMonitor
2 participants
@mhowell24 @tomkerkhove