Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra deploy for Helm chart? #436

Closed
u0078867 opened this issue May 3, 2023 · 6 comments
Closed

Extra deploy for Helm chart? #436

u0078867 opened this issue May 3, 2023 · 6 comments

Comments

@u0078867
Copy link

u0078867 commented May 3, 2023

Is there a way to deploy extra resources using KEDA Helm chart?
For instance, the way it is done via Bitnami charts extraDeploy field, but I don't see it.
Especially, I would like to automatically deploy/undeploy the patch in here: kedacore/keda#4224

Thank you!

@tomkerkhove
Copy link
Member

Can you elaborate a bit how that would work or how they provide this?

@u0078867
Copy link
Author

u0078867 commented May 3, 2023

It is a very simple thing to add, see: https://github.com/bitnami/charts/blob/main/bitnami/rabbitmq/templates/extra-list.yaml

Example above with a RabbitMQ chart, but in Bitnami charts this feature is everywhere.

My goal is to deploy/undeploy the patch automatically with the chart, until the official fix is released.

At the moment, I am solving this with helmfile hooks. But wanted to explore if helm chart extra deploys are feasible.

@tomkerkhove
Copy link
Member

Interesting - What is the motivation to use this over Helm chart dependency? Is it because dependencies don't wait before installing the main chart?

@u0078867
Copy link
Author

u0078867 commented May 5, 2023

Premise - I am learning about helm charts / helmfile and templating, so it could well be I am saying stupidities ...

The money patch here is not an Helm chart but just a bunch of K8s resources. So I thought it would be easier using the Bitnami classical extraDeploy idea.

@tomkerkhove
Copy link
Member

In Helm world, you typically create a Helm chart with a dependency on ours if you want to extend.

But I'm not sure what other @kedacore/keda-helm-contributors think? If they are fine and you want to contribute it then that's fine for me as well.

@mkilchhofer
Copy link
Contributor

duplicate of:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants