Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra objects manifests #394

Closed
fboula opened this issue Feb 17, 2023 · 1 comment · Fixed by #395
Closed

Extra objects manifests #394

fboula opened this issue Feb 17, 2023 · 1 comment · Fixed by #395

Comments

@fboula
Copy link
Contributor

fboula commented Feb 17, 2023

Enable the possibility to add some extra manifest to the chart by passing a yaml list of k8s manifests.

This would allow to create any objects you may require to make your keda install to work. This is extremely useful and easy to maintain, an example can be seen in argo workflow chart

Use-Case

  • Create ClusterTriggerAuthentication
  • Create secrets required for a ClusterTriggerAuthentication
  • Any other resources that would make sense to deploy along the keda chart

If this gets approved, I can work on the pull-request to implement it.

@mkilchhofer
Copy link
Contributor

It is really not good practice to deploy CRDs and resources of that CRDs (= an instance) inside one helm release.

See the comment I made in your PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants