Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector, tolerations and affinity (http-add-on) #212

Merged

Conversation

morganchristiansson
Copy link
Contributor

@morganchristiansson morganchristiansson commented Dec 7, 2021

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • N/A: A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Fixes #

Signed-off-by: Morgan Christiansson <git@mog.se>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomkerkhove tomkerkhove changed the title http-add-on: Add nodeSelector, tolerations and affinity Add nodeSelector, tolerations and affinity (http-add-on) Dec 7, 2021
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @morganchristiansson !

@arschles arschles enabled auto-merge (squash) December 14, 2021 17:26
@arschles arschles enabled auto-merge (squash) December 14, 2021 17:26
@arschles arschles merged commit f76beb2 into kedacore:master Dec 14, 2021
@morganchristiansson
Copy link
Contributor Author

morganchristiansson commented Dec 27, 2021

Can we get a release of keda/keda-add-ons-http chart? Seems it has releases separately from keda/keda chart releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants