Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding WATCH_NAMESPACE option to the HTTP Addon operator #225

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

arschles
Copy link
Collaborator

@arschles arschles commented Jan 7, 2022

kedacore/http-add-on#269 introduces the option to run the HTTP Addon system in a mode that allows one installation to work across all namespaces. This PR exposes new configuration that the change introduces

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles requested a review from a team as a code owner January 7, 2022 17:57
@arschles arschles marked this pull request as draft January 7, 2022 17:57
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arschles arschles marked this pull request as ready for review January 10, 2022 18:20
@tomkerkhove tomkerkhove merged commit 55f7812 into kedacore:main Jan 11, 2022
@arschles arschles deleted the http-add-on-global branch January 11, 2022 17:07
@tomkerkhove tomkerkhove added this to the KEDA HTTP vNext milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants