Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide node selector for KEDA Core #250

Merged
merged 2 commits into from
Feb 15, 2022
Merged

feat: Provide node selector for KEDA Core #250

merged 2 commits into from
Feb 15, 2022

Conversation

tomkerkhove
Copy link
Member

Provide node selector for KEDA Core since we require Linux.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #200

@tomkerkhove
feat: Provide node selector for KEDA Core
e076e99 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove requested a review from a team as a code owner February 15, 2022 13:02
@tomkerkhove tomkerkhove marked this pull request as draft February 15, 2022 13:24
@tomkerkhove tomkerkhove marked this pull request as ready for review February 15, 2022 13:26
@tomkerkhove tomkerkhove enabled auto-merge (squash) February 15, 2022 13:26
JorTurFer
JorTurFer requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only small nit

keda/templates/12-keda-deployment.yaml Outdated Show resolved Hide resolved
@tomkerkhove
🧹
764c445 
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove merged commit 06600ec into main Feb 15, 2022
JorTurFer
JorTurFer approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomkerkhove tomkerkhove deleted the node-selector branch February 15, 2022 16:23
@tomkerkhove tomkerkhove added this to the KEDA Core vNext milestone Apr 27, 2022
@tomkerkhove tomkerkhove removed this from the KEDA Core vNext milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add node selector to enforce Linux
2 participants
@tomkerkhove @JorTurFer