Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add additional annotations templating #334

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Feat: Add additional annotations templating #334

merged 1 commit into from
Dec 5, 2022

Conversation

blottn
Copy link
Contributor

@blottn blottn commented Nov 24, 2022

Allow additional annotations on all resources

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)
  • README is updated with new configuration values (if applicable)

Changes #

  • Add additionalAnnotations parameter

@blottn blottn requested a review from a team as a code owner November 24, 2022 14:15
JorTurFer
JorTurFer requested changes Nov 24, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, could you add new parameter to the readme please?
I have left some small nits inline

keda/templates/01-serviceaccount.yaml Outdated Show resolved Hide resolved
keda/templates/22-metrics-deployment.yaml Outdated Show resolved Hide resolved
keda/templates/23-metrics-service.yaml Outdated Show resolved Hide resolved
@blottn
Copy link
Contributor Author

blottn commented Nov 24, 2022

Updated :) i think i already included the relevant additional README change. Is there another readme which should be updated?

@JorTurFer
Copy link
Member

Updated :) i think i already included the relevant additional README change. Is there another readme which should be updated?

You did it indeed, I didn't see it, my fault :(

@JorTurFer
Copy link
Member

Linter is failing, could you check it? 🙏

@blottn blottn closed this Dec 2, 2022
@blottn
Copy link
Contributor Author

blottn commented Dec 2, 2022

oops didnt mean to close

@blottn blottn reopened this Dec 2, 2022
@blottn
feat: Add additionalAnnotations value and corresponding templating
5cd773f 
Signed-off-by: Nicholas Blott <blottn@tcd.ie>
JorTurFer
JorTurFer approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement

@JorTurFer JorTurFer merged commit 429d8d5 into kedacore:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blottn @JorTurFer