Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing POD_NAMESPACE environment variable to deployments (#405 #405

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: add missing POD_NAMESPACE environment variable to deployments (#405 #405

merged 1 commit into from
Mar 13, 2023

Conversation

michemache
Copy link
Contributor

@michemache michemache commented Mar 13, 2023 •
edited by JorTurFer
Loading

Since Keda 2.10.0 deploying to a different namespace fails, as the POD_NAMESPACE environment variable is missing.

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #403

@michemache michemache requested a review from a team as a code owner March 13, 2023 10:59
@michemache
add POD_NAMESPACE to deployments
4f3a587 
Signed-off-by: Michi U <4169888+michemache@users.noreply.github.com>
@michemache michemache force-pushed the pod-namespace-environment-variable branch from 895ddcf to 4f3a587 Compare March 13, 2023 11:03
@michemache michemache mentioned this pull request Mar 13, 2023
Closed
@JorTurFer JorTurFer enabled auto-merge (squash) March 13, 2023 11:12
@JorTurFer JorTurFer closed this Mar 13, 2023
auto-merge was automatically disabled March 13, 2023 11:12

Pull request was closed

@JorTurFer JorTurFer reopened this Mar 13, 2023
@JorTurFer JorTurFer changed the title fix: add missing POD_NAMESPACE environment variable to deployments fix: add missing POD_NAMESPACE environment variable to deployments (#405 Mar 13, 2023
@JorTurFer JorTurFer merged commit 06ce12c into kedacore:main Mar 13, 2023
@JorTurFer
Copy link
Member

Thanks for the contribution!

@mbaeuerle
Copy link

mbaeuerle commented Mar 13, 2023 •
edited
Loading

Quickfix until there is a new release ready. Add the variable also to the charts' values.yaml:

env:
  - name: POD_NAMESPACE
    valueFrom:
      fieldRef:
        fieldPath: metadata.namespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POD_NAMESPACE environment variable missing
3 participants
@michemache @JorTurFer @mbaeuerle