Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to change port for Webhooks and add hostnetwork #470

Merged
merged 1 commit into from
Jun 22, 2023
Merged

feat: Allow to change port for Webhooks and add hostnetwork #470

merged 1 commit into from
Jun 22, 2023

Conversation

mcantinqc
Copy link
Contributor

Provide a description of what has been changed

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #468

Need this change : kedacore/keda#4712

@mcantinqc mcantinqc requested a review from a team as a code owner June 20, 2023 17:28
This was referenced Jun 20, 2023
Closed
Merged
@mcantinqc
feat: Allow to change port for Webhooks and add hostnetwork
1edd686 
Signed-off-by: Mathieu Cantin <103442330+mcantinqc@users.noreply.github.com>
@zroubalik zroubalik merged commit 36db5aa into kedacore:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to set hostnetwork on Webhook
3 participants
@mcantinqc @zroubalik @JorTurFer