Allow user to set custom livenessProbe and readinessProbe

[dttung2905]

Hi team,

This PR allows user to set custom value for livenessProbe and readinessProbe too

Provide a description of what has been changed

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Commits are signed with Developer Certificate of Origin (DCO - learn more)
• README is updated with new configuration values (if applicable) learn more
• A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #508

[JorTurFer]

nice job!
Does adding the option to all the deployments make sense?

[dttung2905]

@JorTurFer When we set for other deployments like admission webook,

• I'm thinking of deprecating this field webhooks.healthProbePort and opt for the more generic one like livenessProbe or readinessProbe. wdyt?
  

  charts/keda/templates/webhooks/deployment.yaml

  Line 88 in 00a3e0c

  port: {{ .Values.webhooks.healthProbePort }}

  
  

  charts/keda/values.yaml

  Line 86 in 00a3e0c

  healthProbePort: 8081

• Is there a process about deprecation that we can follow? I think we need to add something here right (link) ?

[JorTurFer]

@JorTurFer When we set for other deployments like admission webook,

• I'm thinking of deprecating this field webhooks.healthProbePort and opt for the more generic one like livenessProbe or readinessProbe. wdyt?
  

  charts/keda/templates/webhooks/deployment.yaml

  Line 88 in 00a3e0c

  port: {{ .Values.webhooks.healthProbePort }}

  charts/keda/values.yaml

  Line 86 in 00a3e0c

  healthProbePort: 8081

I think that we hace to maintain both during some period to not break the chart from one version to the next

• Is there a process about deprecation that we can follow? I think we need to add something here right (link) ?

It's a good question. @tomkerkhove @zroubalik , is the helm chart covered by our deprecation policy? I think so but I'd like to read your thoughts

[zroubalik]

I think it is, we should maintain both and deprecate later. See existing approach:

charts/keda/templates/NOTES.txt

Line 44 in 00a3e0c

WARNING - prometheus.operator.serviceMonitor.relabellings is deprecated, please migrate to prometheus.operator.serviceMonitor.relabelings instead.

[dttung2905]

@zroubalik yes. Thats the link I posted above. I will make the changes right away

[zroubalik]

@zroubalik yes. Thats the link I posted above. I will make the changes right away

Nice! Sorry I missed that comment :)

[JorTurFer]

Thanks for the imporvement!