fix: pod monitor port name does not match deployment spec #602

pragmaticivan · 2024-01-27T17:40:34Z

PodMonitor port name is set as http but the deployment port name is set as metrics.

I have verified that my change is according to the deprecations & breaking changes policy
Commits are signed with Developer Certificate of Origin (DCO - learn more)
README is updated with new configuration values (if applicable) learn more
A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Fixes #601

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

keda/templates/manager/podmonitor.yaml

JorTurFer · 2024-01-28T17:55:13Z

Nice catch!

pragmaticivan requested a review from a team as a code owner January 27, 2024 17:40

fix: pod monitor port name does not match deployment spec

28e86af

Signed-off-by: Ivan Santos <301291+pragmaticivan@users.noreply.github.com>

pragmaticivan force-pushed the fix-podmonitor-port-name branch from 1218707 to 28e86af Compare January 27, 2024 17:41

pragmaticivan commented Jan 27, 2024

View reviewed changes

keda/templates/manager/podmonitor.yaml Show resolved Hide resolved

JorTurFer approved these changes Jan 28, 2024

View reviewed changes

JorTurFer enabled auto-merge (squash) January 28, 2024 17:55

JorTurFer merged commit 395ea88 into kedacore:main Jan 28, 2024
37 checks passed

Provide feedback