-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add "none" as identity provider #618
Conversation
Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
Nice catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to include this change in multiple places (in the same places as the core PR), could you update all of them? 🙏
Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
Thanks for your contribution! ❤️ |
* support "none" as identity provider Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com> * add in other places Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com> * Update crd-clustertriggerauthentications Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com> * Update crd-triggerauthentications.yaml Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com> --------- Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
identity provider: "none" is officially supported and allowed value based on the docs and keda golang structs:
https://github.com/kedacore/keda/blob/main/apis/keda/v1alpha1/triggerauthentication_types.go#L123
and in the docs:
https://keda.sh/docs/2.13/concepts/authentication/
its missing since crds refactor (2.13)
Checklist