Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "none" as identity provider #618

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Conversation

roee-hersh
Copy link
Contributor

@roee-hersh roee-hersh commented Mar 12, 2024

identity provider: "none" is officially supported and allowed value based on the docs and keda golang structs:

https://github.com/kedacore/keda/blob/main/apis/keda/v1alpha1/triggerauthentication_types.go#L123

const (
	PodIdentityProviderNone          PodIdentityProvider = "none"
	PodIdentityProviderAzure         PodIdentityProvider = "azure"
	PodIdentityProviderAzureWorkload PodIdentityProvider = "azure-workload"
	PodIdentityProviderGCP           PodIdentityProvider = "gcp"
	PodIdentityProviderAwsEKS        PodIdentityProvider = "aws-eks"
	PodIdentityProviderAwsKiam       PodIdentityProvider = "aws-kiam"
	PodIdentityProviderAws           PodIdentityProvider = "aws"
)

and in the docs:
https://keda.sh/docs/2.13/concepts/authentication/

apiVersion: keda.sh/v1alpha1
kind: TriggerAuthentication
metadata:
  name: {trigger-authentication-name}
  namespace: default # must be same namespace as the ScaledObject
spec:
  podIdentity:
      provider: none | azure | azure-workload | aws | aws-eks | aws-kiam | gcp  # Optional. Default: none
...

its missing since crds refactor (2.13)

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable) learn more
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
@roee-hersh roee-hersh requested a review from a team as a code owner March 12, 2024 10:56
@roee-hersh roee-hersh changed the title support "none" as identity provider fix: add "none" as identity provider Mar 12, 2024
@JorTurFer
Copy link
Member

Nice catch!
Although you just keep it unset, it's also true that none should be accepted based on docs. I've opened a PR into KEDA code to reflect this change too: kedacore/keda#5593

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to include this change in multiple places (in the same places as the core PR), could you update all of them? 🙏

Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
@JorTurFer
Copy link
Member

Thanks for your contribution! ❤️

@JorTurFer JorTurFer enabled auto-merge (squash) March 15, 2024 23:20
@JorTurFer JorTurFer merged commit 8231b9e into kedacore:main Mar 15, 2024
37 checks passed
@roee-hersh roee-hersh deleted the patch-1 branch March 17, 2024 09:00
QuentinBisson pushed a commit to giantswarm/keda-upstream that referenced this pull request Jul 1, 2024
* support "none" as identity provider

Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>

* add in other places

Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>

* Update crd-clustertriggerauthentications

Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>

* Update crd-triggerauthentications.yaml

Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>

---------

Signed-off-by: roee-hersh <113914991+roee-hersh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants