Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship KEDA chart v2.14.1 #632

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Ship KEDA chart v2.14.1 #632

merged 3 commits into from
Apr 29, 2024

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Apr 28, 2024 •
edited
Loading

This PR fix 2 different issues (and ship a new version)

  • During the release process, I used the wrong CRD values, so I dropped some options from OpenAPI. This PR restores them and ship the new helm chart.
  • During this PR, we missed the default GET over *. This PR enables * as default to not break the current usages.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes kedacore/keda#5752
Fixes #633

@JorTurFer JorTurFer requested a review from a team as a code owner April 28, 2024 11:34
@JorTurFer JorTurFer mentioned this pull request Apr 28, 2024
Closed
@JorTurFer
Ship KEDA chart v2.14.1
7e08dbb 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix RBAC issue
f537f2d 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
re package the chart with latest changes
3c13883 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@tomkerkhove tomkerkhove merged commit 9ab7049 into kedacore:main Apr 29, 2024
37 checks passed
@JorTurFer JorTurFer deleted the 2-14-1 branch April 29, 2024 06:16
QuentinBisson pushed a commit to giantswarm/keda-upstream that referenced this pull request Jul 1, 2024
@JorTurFer @QuentinBisson
Ship KEDA chart v2.14.1 (kedacore#632)
1a9d6e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing RBAC permissions for * 2.14.0 release cannot use jobTargetRef template metadata labels
2 participants
@JorTurFer @tomkerkhove