reimplement custom interceptor metrics #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-718
branch
4 times, most recently
from
b3c36b3
to
1498ce5
Compare
Signed-off-by: Pedro Tôrres <pedrotorres@microsoft.com>
t0rr3sp3dr0
force-pushed
the
pedrotorres/issue-718
branch
from
1498ce5
to
16b3de6
Compare
JorTurFer
approved these changes
Jun 26, 2023
tomkerkhove
reviewed
Jun 26, 2023
|
fuck, the auto-merge was enabled :( sorry |
|
@tomkerkhove, do you mean more tests? I’ve added Interceptor-related tests to all 4 gRPC methods. https://github.com/kedacore/http-add-on/pull/720/files#diff-b0165c879226f6239e3bd158629f647c24a21b79aafba82b7b5df7e78a185c25 |
|
the bug still with us. Version 0.5.3 |
|
This PR hasn't been released yet. I think that we'll cut a release during this month |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom metrics for the Interceptor were mistakenly removed on #669. This patch reimplements this functionality and adds the missing ScaledObject for the Interceptor to the manifest directory.
Checklist
README.mddocs/directoryRelated-to: kedacore/charts#487
Fixes: #718