Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: new experimental Kafka scaler #1187

Merged
merged 5 commits into from
Sep 25, 2023
Merged

docs: new experimental Kafka scaler #1187

merged 5 commits into from
Sep 25, 2023

Conversation

sansmoraxz
Copy link
Contributor

@sansmoraxz sansmoraxz commented Jul 15, 2023 •
edited
Loading

Docs for experimental kafka scaler which is based on kafka-go

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#4692 kedacore/keda#3431

Relates to kedacore/keda#4801

@sansmoraxz
Add docs for kafka-x
e4b4ec8 
- The experimental scaler which is based on `kafka-go`

Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
@netlify
Copy link

netlify bot commented Jul 15, 2023 •
edited
Loading

❌ Deploy Preview for keda failed.

Name Link
🔨 Latest commit 327e682
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/64c51dae4611fa0007934257

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@sansmoraxz sansmoraxz mentioned this pull request Jul 15, 2023
Merged
7 tasks
@sansmoraxz sansmoraxz marked this pull request as ready for review July 15, 2023 18:17
@sansmoraxz sansmoraxz requested a review from a team as a code owner July 15, 2023 18:17
@sansmoraxz
Add missing aws msk docs for kafka-x scaler
13b7ef3 
Signed-off-by: Souyama Debnath <souyama.debnath@atos.net>
@sansmoraxz
Copy link
Contributor Author

Weird. When I try to run locally, the file is being generated.

JorTurFer
JorTurFer reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
AFAIR, there are some gaps comparing this new scaler with the already existing scaler with some features not implemented yet. Could you document them as part of the scaler page? Thanks to it users can decide which flavor matches better with their requirements

content/docs/2.12/scalers/kafka-x.md Outdated Show resolved Hide resolved
@sansmoraxz @JorTurFer
Maintainer is Community
e815071 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Souyama <souyama.debnath@atos.net>
@sansmoraxz
Copy link
Contributor Author

Sure will add those to docs.

Also this file should probably be renamed. How should we approach this?
The sarama implementation file is named apache-kafka.md

@sansmoraxz sansmoraxz changed the title Add docs for kafka-x docs: for new experimental Kafka scaler Jul 27, 2023
@sansmoraxz sansmoraxz changed the title docs: for new experimental Kafka scaler docs: new experimental Kafka scaler Jul 27, 2023
@sansmoraxz
Rename kafka-x to apache-kafka
b1dad35 
Signed-off-by: Souyama <souyama.debnath@atos.net>
@sansmoraxz
Add feature diff compared to existing kafka scaler
327e682 
Signed-off-by: Souyama <souyama.debnath@atos.net>
@zroubalik zroubalik merged commit 8755614 into kedacore:main Sep 25, 2023
@tomkerkhove tomkerkhove mentioned this pull request Sep 25, 2023
Merged
1 task
@zroubalik zroubalik mentioned this pull request Sep 25, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees

@zroubalik zroubalik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change kafka library to kafka-go
3 participants
@sansmoraxz @zroubalik @JorTurFer