docs(prometheus): remove deprecated metricName from examples in v2.13 #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Nick Badger <nbadger@mintel.com>
nabadger
force-pushed
the
remove-deprecated-metricname-prom-scaler
branch
from
a9d6f3e to
77d76bf
Compare
|
I believe I've fixed the DCO sign-off (amended the commit msg) and re-pushed this. |
zroubalik
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Please remove it from version 2.14 as well.
Also, the DCO is still a problem, try:To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin remove-deprecated-metricname-prom-scaler
|
I'm going to merge this as part of my release PR, thanks for the contribution! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reference to
metricNamein the prometheus scaler docs is still present inv2.13. This removes it.Relates to kedacore/keda#4899
Checklist
Fixes #