Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and deprecate unused variables and correct queueDepth default in IBM MQ scaler #1445

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Aug 5, 2024

  • The current documentation states that the default queueDepth is 5, while the code default is 20. The documentation will be updated to reflect the correct default value of 20, aligning it with the code.
  • The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code is removed. The documentation is updated accordingly.
  • The parameter tlsDisabled is set to DEPRECATED. All other scalers use the parameter unsafeSsl. To maintain consistency across the other scalers, the code related to tlsDisabled is set to deprecated, as unsafeSsl already handles this functionality.
  • Finally, some minor adjustments to the documentation to keep the formatting the same.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related: 6034

@rickbrouwer rickbrouwer requested a review from a team as a code owner August 5, 2024 10:09
Copy link

github-actions bot commented Aug 5, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 1b54369
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/66c4571e32a8bc000839c595
😎 Deploy Preview https://deploy-preview-1445--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rickbrouwer rickbrouwer marked this pull request as draft August 5, 2024 18:51
@rickbrouwer rickbrouwer changed the title Remove unused variables and correct queueDepth default in IBM MQ scaler Remove and deprecate unused variables and correct queueDepth default in IBM MQ scaler Aug 12, 2024
@rickbrouwer rickbrouwer marked this pull request as ready for review August 12, 2024 14:12
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@JorTurFer
Copy link
Member

Are all deprecated?
image

I thought that only the tls one is deprecated

@rickbrouwer
Copy link
Contributor Author

rickbrouwer commented Aug 20, 2024

Are all deprecated? image

I thought that only the tls one is deprecated

Yes, sorry. My bad. I misunderstood something. I have changed it back.

rickbrouwer and others added 2 commits August 20, 2024 10:42
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
@JorTurFer JorTurFer merged commit 8dadad2 into kedacore:main Aug 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants