-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for new kubernetes workload scaler #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
JorTurFer
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
August 5, 2021 15:47
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
5 tasks
zroubalik
reviewed
Aug 5, 2021
tomkerkhove
reviewed
Aug 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some remarks, what do you think @zroubalik ?
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
As we discussed @tomkerkhove @zroubalik, I have just removed the possibility to select the namespace. The search scope is the namespace where the scaledobject is placed |
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
tomkerkhove
approved these changes
Aug 6, 2021
zroubalik
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jorturfer jorge_turrado@hotmail.es
Added documentation for new kubernetes workload scaler
Checklist
Relates to kedacore/keda#1735
Relates to kedacore/keda#2010