Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for new kubernetes workload scaler #501

Merged
merged 7 commits into from
Aug 6, 2021
Merged

Added documentation for new kubernetes workload scaler #501

merged 7 commits into from
Aug 6, 2021

Conversation

JorTurFer
Copy link
Member

Signed-off-by: jorturfer jorge_turrado@hotmail.es

Added documentation for new kubernetes workload scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to kedacore/keda#1735
Relates to kedacore/keda#2010

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some remarks, what do you think @zroubalik ?

content/docs/2.4/scalers/kubernetes-workload.md Outdated Show resolved Hide resolved
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

As we discussed @tomkerkhove @zroubalik, I have just removed the possibility to select the namespace. The search scope is the namespace where the scaledobject is placed

Signed-off-by: jorturfer <jorge_turrado@hotmail.es>
@zroubalik zroubalik merged commit 3166137 into kedacore:master Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants