Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Datadog scaler #602

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

arapulido
Copy link
Contributor

This PR adds documentation for a new Datadog scaler.

Related PR for the scaler itself: kedacore/keda#2354

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs 2 improvements

content/docs/2.6/scalers/datadog.md Show resolved Hide resolved
content/docs/2.6/scalers/datadog.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

I'll be a pain but can you align with this formatting please?
https://github.com/kedacore/keda-docs#writing-documentation-for-a-scaler

@arapulido
Copy link
Contributor Author

I'll be a pain but can you align with this formatting please? https://github.com/kedacore/keda-docs#writing-documentation-for-a-scaler

Not a pain at all! I had missed that! Thanks a lot for the quick reviews, I will fix that now.

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a ton @arapulido 🎉

@zroubalik zroubalik merged commit d0b9086 into kedacore:main Jan 12, 2022
daniel-yavorovich pushed a commit to dysnix/keda-docs that referenced this pull request Jan 18, 2022
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
daniel-yavorovich pushed a commit to dysnix/keda-docs that referenced this pull request Jan 18, 2022
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
daniel-yavorovich pushed a commit to dysnix/keda-docs that referenced this pull request Jan 26, 2022
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
daniel-yavorovich pushed a commit to dysnix/keda-docs that referenced this pull request Jan 26, 2022
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants