-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Datadog scaler #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs 2 improvements
I'll be a pain but can you align with this formatting please? |
Not a pain at all! I had missed that! Thanks a lot for the quick reviews, I will fix that now. |
cae2c31
to
906d240
Compare
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
906d240
to
7e72922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a ton @arapulido 🎉
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
This PR adds documentation for a new Datadog scaler.
Related PR for the scaler itself: kedacore/keda#2354
Checklist