Add documentation for ActiveMQ Scaler #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com>
melisatanrverdi
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
tomkerkhove
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Added a quick remark. Would you mind aligning with our doc guidance please?
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com>
tomkerkhove
approved these changes
Dec 13, 2021
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com>
arschles
reviewed
Dec 14, 2021
content/docs/2.6/scalers/activemq.md
Outdated
| - `destinationName` - Name of the queue to check for the message count. | ||
| - `brokerName` - Name of the broker as defined in ActiveMQ. | ||
| - `targetQueueSize` - Target value for queue length passed to the scaler. The scaler will cause the replicas to increase if the queue message count is greater than the target value per active replica. (Default: `10`, Optional) | ||
| - `restAPITemplate` - Template to build REST API url to get queue size. (Default: `"http://<<managementEndpoint>>/api/jolokia/read/org.apache.activemq:type=Broker,brokerName=<<brokerName>>,destinationType=Queue,destinationName=<<destinationName>>/QueueSize"`, Optional) |
There was a problem hiding this comment.
am I mistaken or is the template using the Go text/template syntax now?
There was a problem hiding this comment.
Yes, I corrected default template syntax.
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com>
tomkerkhove
approved these changes
Dec 15, 2021
5 tasks
zroubalik
approved these changes
Jan 3, 2022
daniel-yavorovich
pushed a commit
to dysnix/keda-docs
that referenced
this pull request
Jan 18, 2022
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
daniel-yavorovich
pushed a commit
to dysnix/keda-docs
that referenced
this pull request
Jan 18, 2022
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
daniel-yavorovich
pushed a commit
to dysnix/keda-docs
that referenced
this pull request
Jan 26, 2022
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
daniel-yavorovich
pushed a commit
to dysnix/keda-docs
that referenced
this pull request
Jan 26, 2022
Signed-off-by: melisatanrverdi <melisatanrverdi@gmail.com> Signed-off-by: Daniel Yavorovych <daniel@dysnix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: melisatanrverdi melisatanrverdi@gmail.com
Provide documentation for ActiveMQ scaler.
Checklist
Relates to kedacore/keda#2305
Relates to kedacore/keda#2120