Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change tls values from true/false to enable/disable #648

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

gunniwho
Copy link
Contributor

@gunniwho gunniwho commented Feb 8, 2022

Signed-off-by: Gunnar Palsson gunniwho@gmail.com

Provide a description of what has been changed

Changed the tls values from true/false to enable/disable. This is accompanying my PR to allow disable as a valid value here.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#2608
Related kedacore/keda#2611

Signed-off-by: Gunnar Palsson <gunniwho@gmail.com>
@netlify
Copy link

netlify bot commented Feb 8, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 8dec1cf

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/620439ab09eb330007319c55

😎 Browse the preview: https://deploy-preview-648--keda.netlify.app

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this does not seem to be a recent change but rather stale docs. Would you mind updating the previous versions of this?

Signed-off-by: Gunnar Palsson <gunniwho@gmail.com>
@gunniwho
Copy link
Contributor Author

gunniwho commented Feb 9, 2022

LGTM, but this does not seem to be a recent change but rather stale docs. Would you mind updating the previous versions of this?

done

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomkerkhove
Copy link
Member

Waiting for feature to be merged first

@JorTurFer JorTurFer merged commit f85f9fa into kedacore:main Feb 14, 2022
@JorTurFer
Copy link
Member

thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to specify TLS disabled for Kafka scaler
5 participants