-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datadog: add more information related to polling intervals that may affect rate limiting #702
Datadog: add more information related to polling intervals that may affect rate limiting #702
Conversation
…olling intervals Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
0deb05a
to
9e2dc21
Compare
✔️ Deploy Preview for keda ready! 🔨 Explore the source changes: 0deb05a 🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/62273dad5e786d0008ce0bc1 😎 Browse the preview: https://deploy-preview-702--keda.netlify.app |
✔️ Deploy Preview for keda ready! 🔨 Explore the source changes: 7033869 🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/622f41d59a9e280009623c41 😎 Browse the preview: https://deploy-preview-702--keda.netlify.app/docs/2.6/scalers/datadog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments. Also, please line-wrap the paragraphs you added to ~80 characters, it helps make reviews and (subsequent) diffs more manageable.
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small adjustment needed for the link reference you updated -- see inline comments. Otherwise, LGTM. I'll let others approve the content.
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
…ffect rate limiting (kedacore#702) Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com> Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Polling interval is different (and controlled with different parameters) when scaling from 0 to 1, to when scaling between 1 and N. As this is important to understand for Datadog (as it may affect reaching rate limits sooner), this PR adds a section that explains this a bit better.
Checklist