Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog: add more information related to polling intervals that may affect rate limiting #702

Merged
merged 7 commits into from
Mar 14, 2022

Conversation

arapulido
Copy link
Contributor

Polling interval is different (and controlled with different parameters) when scaling from 0 to 1, to when scaling between 1 and N. As this is important to understand for Datadog (as it may affect reaching rate limits sooner), this PR adds a section that explains this a bit better.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

…olling intervals

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
@netlify
Copy link

netlify bot commented Mar 8, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 0deb05a

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/62273dad5e786d0008ce0bc1

😎 Browse the preview: https://deploy-preview-702--keda.netlify.app

@netlify
Copy link

netlify bot commented Mar 8, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 7033869

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/622f41d59a9e280009623c41

😎 Browse the preview: https://deploy-preview-702--keda.netlify.app/docs/2.6/scalers/datadog

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments. Also, please line-wrap the paragraphs you added to ~80 characters, it helps make reviews and (subsequent) diffs more manageable.

content/docs/2.6/scalers/datadog.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/datadog.md Outdated Show resolved Hide resolved
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
@arapulido arapulido requested review from JorTurFer and chalin March 8, 2022 14:46
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small adjustment needed for the link reference you updated -- see inline comments. Otherwise, LGTM. I'll let others approve the content.

content/docs/2.6/scalers/datadog.md Outdated Show resolved Hide resolved
content/docs/2.7/scalers/datadog.md Outdated Show resolved Hide resolved
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
@zroubalik zroubalik merged commit 2dd30e2 into kedacore:main Mar 14, 2022
samueleresca pushed a commit to samueleresca/keda-docs that referenced this pull request Mar 17, 2022
…ffect rate limiting (kedacore#702)

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants