Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new metricUnavailableValue #710

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

arapulido
Copy link
Contributor

@arapulido arapulido commented Mar 11, 2022

Signed-off-by: Ara Pulido ara.pulido@datadoghq.com

The Datadog scaler, starting on 2.7, will have a new optional parameter metricUnavailableValue that will fill the metric value to a specified by the user value, if Datadog didn't find a metric value for the specified time window

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes kedacore/keda#2694

Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
@netlify
Copy link

netlify bot commented Mar 11, 2022

✔️ Deploy Preview for keda ready!

🔨 Explore the source changes: 6616ab6

🔍 Inspect the deploy log: https://app.netlify.com/sites/keda/deploys/622b1d4a596d920009a5e217

😎 Browse the preview: https://deploy-preview-710--keda.netlify.app

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for feature to be merged

@arapulido
Copy link
Contributor Author

@zroubalik shall this be merged now that the feature is merged? Thanks!

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit b70cfdd into kedacore:main Mar 14, 2022
samueleresca pushed a commit to samueleresca/keda-docs that referenced this pull request Mar 17, 2022
Signed-off-by: Ara Pulido <ara.pulido@datadoghq.com>
Signed-off-by: Samuele Resca <samuele.resca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants