Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caConfigMaps field to KedaOperatorSpec #232

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Jun 20, 2024

This field causes the operator to mount any referenced configmaps
and to run with --ca-dir= flags pointing to their mount points.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related to kedacore/keda#5859

@joelsmith joelsmith changed the title Add caConfigMaps field to KedaOperatorSpec WIP: Add caConfigMaps field to KedaOperatorSpec Jun 20, 2024
@joelsmith joelsmith changed the title WIP: Add caConfigMaps field to KedaOperatorSpec Add caConfigMaps field to KedaOperatorSpec Jun 20, 2024
This field causes the operator to mount any referenced configmaps
and to run with --ca-dir= flags pointing to their mount points.

Signed-off-by: Joel Smith <joelsmith@redhat.com>
@jkyros
Copy link
Contributor

jkyros commented Jun 20, 2024

Looks good to me, the deployments end up looking like this:

     containers:
      - args:
        - --leader-elect
        - --zap-log-level=error
        - --zap-encoder=json
        - --zap-time-encoding=rfc3339
        - --enable-cert-rotation=false
        - --ca-dir=/custom/ca0
        - --ca-dir=/custom/ca1
     ...
        volumeMounts:
        - mountPath: /certs
          name: certificates
          readOnly: true
        - mountPath: /custom/ca0
          name: cabundle0
        - mountPath: /custom/ca1
          name: cabundle1
    ...
      - configMap:
          defaultMode: 420
          name: keda-ocp-cabundle
        name: cabundle0
      - configMap:
          defaultMode: 420
          name: foo
        name: cabundle1

It does break compatibility with old operands because they don't understand the --ca-dir argument, and this moves the keda-ocp-bundle to use that argument, but it sounds like we plan to release this as > 2.14.0 , which should be fine because a matching > 2.14.0 operand will have kedacore/keda#5859. (I'm just mentioning it for posterity)

Also, I'm in the middle of refactoring that functionality test, I promise. 😄

/lgtm

@joelsmith joelsmith merged commit 81ff7b1 into kedacore:main Jun 20, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants