Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have helm chart delete CRD or add option to not create CRD #105

Closed
lee0c opened this issue Apr 22, 2019 · 0 comments · Fixed by #107
Closed

Have helm chart delete CRD or add option to not create CRD #105

lee0c opened this issue Apr 22, 2019 · 0 comments · Fixed by #107
Assignees

Comments

@lee0c
Copy link
Contributor

lee0c commented Apr 22, 2019

Deleting a helm release of keda & then re-installing fails currently as helm does not delete CRDs by default. There are a few possible work arounds:

  1. Add a values file flag that sets whether or not CRDs are created
  2. Add a hook that cleans up the ScaledObject CRD post-deletion
  3. Add a hook that cleans up the ScaledObject CRD pre-install (wipes old versions if they exist)

Might want to do 1. & one of 2. or 3. - since killing the ScaledObject CRD will kill deployed ScaledObjects afaik, adding in option 1. & making either 2. or 3. dependent on that value will give users a use case where they don't touch their deployed ScaledObjects while making other edits

Haven't checked the func cli behavior for this issue but the func cli also doesn't offer a command to delete/remove keda from a cluster so at that point it's manual anyway.

@lee0c lee0c self-assigned this Apr 26, 2019
preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
…acore#105)

* Added documentation for Authenticate to AWS with dedicated role without AssumeRole permissions (kedacore#656)

* rename podIdentity to identityOwner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant