Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate KEDA scale logic with coming HPA scale to zero features #208

Open
jeffhollan opened this issue May 17, 2019 · 14 comments
Open

Integrate KEDA scale logic with coming HPA scale to zero features #208

jeffhollan opened this issue May 17, 2019 · 14 comments
Labels
feature All issues for new features that have been committed to P1 stale-bot-ignore All issues that should not be automatically closed by our stale bot upstream-integration All issues related to upstream Kubernetes/community

Comments

@jeffhollan
Copy link
Member

kubernetes/kubernetes#74526

@jeffhollan jeffhollan added the P1 label May 17, 2019
@jeffhollan jeffhollan added this to the Triaged milestone May 17, 2019
@mikhailshilkov
Copy link

If I read it correctly, the scale to/from zero feature of HPA has been released in 1.16. Does it mean that it will replace the KEDA way of enabling/disabling the deployment any time soon? Does it make the whole controller obsolete?

@jeffhollan
Copy link
Member Author

A few things to note

  • While HPA can scale custom metrics to zero, it still needs metrics to scale. So KEDA still relevant in being a single spot for a bunch of metric publishers and authentication with them

  • Will also be some time before 1.16 is widely adopted so in interim good to have.

We should do it but just means one of the things KEDA does today it can offload to HPA, but would still need to do others

@mikhailshilkov
Copy link

Yes, I'm not questioning KEDA, I guess the whole controller was an exaggeration but handleScaleLoop can probably go.
Thanks for the quick response!

@jeffhollan
Copy link
Member Author

Makes sense. The other thing I want to check out (let me know if others know in meantime) is the polling interval and latency of HPA scaling from 0. In KEDA it’s configurable. Not sure if we’d leave KEDA as an option to still drive if it’s providing some additional features

@tomkerkhove
Copy link
Member

We should check how this impacts 2.0 /cc @zroubalik

@tomkerkhove tomkerkhove modified the milestones: Triaged, v2.0 May 4, 2020
@zroubalik
Copy link
Member

zroubalik commented May 4, 2020

It's still alpha in kubernetes: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features (search for HPAScaleToZero). It has to be enabled in the cluster by admin and it is not stable enough to be used by KEDA. We could include this later.

@tomkerkhove
Copy link
Member

Sound like a plan!

@tomkerkhove tomkerkhove removed this from the v2.0 milestone May 4, 2020
@stale
Copy link

stale bot commented Oct 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 13, 2021
@tomkerkhove
Copy link
Member

/keep-alive

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 14, 2021
@tomkerkhove tomkerkhove added feature All issues for new features that have been committed to stale All issues that are marked as stale due to inactivity labels Oct 14, 2021
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 14, 2021
@tomkerkhove tomkerkhove added stale All issues that are marked as stale due to inactivity upstream-integration All issues related to upstream Kubernetes/community labels Oct 14, 2021
@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 14, 2021
preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com>
preflightsiren pushed a commit to preflightsiren/keda that referenced this issue Nov 7, 2021
* Welcome Apache Airflow as a user!

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Resize image

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Sort alphabetically

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

* Fix users icon layout (kedacore#208)

Signed-off-by: Ahmed ElSayed <ahmels@microsoft.com>

* Welcome Apache Airflow as a user!

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
@JorTurFer
Copy link
Member

Does having this issue open make sense?

@tomkerkhove
Copy link
Member

It depends - Do we align or still have our own approach? If the latter, why?

@JorTurFer
Copy link
Member

JorTurFer commented Feb 2, 2023

HPA still doesn't support scale to 0, we deactivate the HPA according to official docs, but the scale to zero features aren't available yet in the HPA itself. We do that part with the operator (activation phase)

@zroubalik
Copy link
Member

This KEP is still active, kubernetes/enhancements#2022

Let's keep this issue opened to track this effort.

@tomkerkhove
Copy link
Member

Ok; I thought this was shipped already.

@JorTurFer JorTurFer added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature All issues for new features that have been committed to P1 stale-bot-ignore All issues that should not be automatically closed by our stale bot upstream-integration All issues related to upstream Kubernetes/community
Projects
Status: Proposed
Development

No branches or pull requests

5 participants