Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get all metrics in the Operator and use gRPC to send them to Metrics Server #3920

Closed
zroubalik opened this issue Nov 29, 2022 · 0 comments · Fixed by #3861
Closed

Get all metrics in the Operator and use gRPC to send them to Metrics Server #3920

zroubalik opened this issue Nov 29, 2022 · 0 comments · Fixed by #3861
Assignees
@zroubalik
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@zroubalik
Copy link
Member

Proposal

This reduces number of open connections from KEDA, as there is a single client talking to an external service. It simplifies Metrics Server logic and opens door for introducing metrics value cache.

Use-Case

No response

Anything else?

No response
@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Nov 29, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Nov 29, 2022
This was referenced Nov 29, 2022
Closed
Merged
@zroubalik zroubalik self-assigned this Nov 29, 2022
Repository owner moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Nov 29, 2022
JorTurFer pushed a commit that referenced this issue Nov 29, 2022
@zroubalik
Metrics Server: use gRPC connection to get metrics from Operator (#3861)
2492a43 
Fixes #3920
Fixes #3919
josephangbc pushed a commit to josephangbc/keda that referenced this issue Dec 6, 2022
@zroubalik @josephangbc
Metrics Server: use gRPC connection to get metrics from Operator (ked…
1819e83 
…acore#3861)

Fixes kedacore#3920
Fixes kedacore#3919
josephangbc pushed a commit to josephangbc/keda that referenced this issue Dec 6, 2022
@zroubalik @josephangbc
Metrics Server: use gRPC connection to get metrics from Operator (ked…
18f3e7f 
…acore#3861)

Fixes kedacore#3920
Fixes kedacore#3919
@prashathsenthil prashathsenthil mentioned this issue Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zroubalik zroubalik

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Metrics Server: use gRPC connection to get metrics from Operator zroubalik/keda
1 participant
@zroubalik