Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Hub Scaler should use parameter eventHubName when the connection string doesn't contain the EntityPath #3922

Closed
v-shenoy opened this issue Nov 29, 2022 · 0 comments · Fixed by #3924
Closed

Event Hub Scaler should use parameter eventHubName when the connection string doesn't contain the EntityPath #3922

v-shenoy opened this issue Nov 29, 2022 · 0 comments · Fixed by #3924
Assignees
@v-shenoy
Labels
azure All issues concerning integration with Azure feature-request All issues for new features that have not been committed to needs-discussion scaler-azure-event-hubs

Comments

@v-shenoy
Copy link
Contributor

Proposal

If the connection string provided doesn't contain the EntityPath (i.e - it's the connection string for the Event Hub namespace, and not the Event Hub itself), the scaler should use the eventHubName parameter and append it to the connection string.

Use-Case

The Functions Event Hub trigger expects the connection string for the namespace, and not a hub. This differs from the format that KEDA expects for the connection string. The pod for the EH Function will generally contain the namespace connection string (without the EntityPath). This makes it harder to generate scaled objects through code.

Anything else?

No response
@v-shenoy v-shenoy added needs-discussion feature-request All issues for new features that have not been committed to labels Nov 29, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Nov 29, 2022
@v-shenoy v-shenoy added azure All issues concerning integration with Azure scaler-azure-event-hubs labels Nov 29, 2022
@v-shenoy v-shenoy self-assigned this Nov 29, 2022
@v-shenoy v-shenoy mentioned this issue Nov 29, 2022
Merged
4 tasks
Repository owner moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@v-shenoy v-shenoy

Labels
azure All issues concerning integration with Azure feature-request All issues for new features that have not been committed to needs-discussion scaler-azure-event-hubs
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
1 participant
@v-shenoy