Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support using connection strings for Event Hub namespace instead of the Event Hub itself. #3924

Merged
merged 4 commits into from
Nov 29, 2022
Merged

feat: Support using connection strings for Event Hub namespace instead of the Event Hub itself. #3924

merged 4 commits into from
Nov 29, 2022

Conversation

v-shenoy
Copy link
Contributor

@v-shenoy v-shenoy commented Nov 29, 2022 •
edited
Loading

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Fixes #3922

Relates to kedacore/keda-docs#988

@v-shenoy
Fix path variable for WSL
37b3262 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Append EntityPath if not present
1afef6e 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Update CHANGELOG.
f438b5b 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy
Update unit tests
fae4963 
Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy requested a review from a team as a code owner November 29, 2022 11:27
@v-shenoy v-shenoy changed the title Support using connection strings for Event Hub namespace instead of the Event Hub itself. feat: Support using connection strings for Event Hub namespace instead of the Event Hub itself. Nov 29, 2022
JorTurFer
JorTurFer reviewed Nov 29, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I think we need to update docs as well because eventHubName is optional and only required in case of pod identity , but now it could be also required with we use namespace connection string instead of eh connection string

@v-shenoy v-shenoy mentioned this pull request Nov 29, 2022
Merged
1 task
@v-shenoy
Copy link
Contributor Author

v-shenoy commented Nov 29, 2022 •
edited
Loading

LGTM! I think we need to update docs as well because eventHubName is optional and only required in case of pod identity , but now it could be also required with we use namespace connection string instead of eh connection string

Haha, was in the middle of doing it.

@JorTurFer
Copy link
Member

JorTurFer commented Nov 29, 2022 •
edited by github-actions bot
Loading

/run-e2e event*
Update: You can check the progress here

@zroubalik zroubalik merged commit 8dc8aff into kedacore:main Nov 29, 2022
@v-shenoy v-shenoy deleted the eh-conn branch November 29, 2022 16:58
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
@v-shenoy @josephangbc
feat: Support using connection strings for Event Hub namespace instea…
3a570ec 
…d of the Event Hub itself. (kedacore#3924)

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
josephangbc pushed a commit to josephangbc/keda that referenced this pull request Dec 6, 2022
@v-shenoy @josephangbc
feat: Support using connection strings for Event Hub namespace instea…
546e6db 
…d of the Event Hub itself. (kedacore#3924)

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event Hub Scaler should use parameter eventHubName when the connection string doesn't contain the EntityPath
3 participants
@v-shenoy @JorTurFer @zroubalik