KEDA CI is updating the 1.0.0 image #489
Comments
|
Woops 😅 |
This was referenced Nov 28, 2019
|
Yeah.... I wanted to discuss what we want to do there. I was leaning more towards increment the version as Jeff suggested. Didn't expect there will be a break as I was just merging doc PRs. |
|
Not a huge deal and easy fix. Yeah we can sort it out next week. |
|
hi @jeffhollan @tomkerkhove @ahmelsayed Why not set up to build a new image only when tagging, then the form of the tag is similar to v1.0.1? master branch can always be in dev and merge stable future. |
|
Yes I think that’s what we’re leaning towards. When we tag / release we generate a new tag. When a PR is merged it just automatically updates the “master” tag but no others. |
ahmelsayed
added a commit
that referenced
this issue
Dec 3, 2019
ahmelsayed
added a commit
that referenced
this issue
Dec 3, 2019
ahmelsayed
added a commit
that referenced
this issue
Dec 3, 2019
ahmelsayed
added a commit
that referenced
this issue
Dec 3, 2019
ahmelsayed
added a commit
that referenced
this issue
Dec 4, 2019
ahmelsayed
added a commit
that referenced
this issue
Dec 4, 2019
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this issue
Nov 7, 2021
…ex (kedacore#489) * Update RabbitMQ Scaler documentation to include the option of use regex in case of http queue Signed-off-by: jorturfer <jorge_turrado@hotmail.es> * Update the documentation with the suggestions Signed-off-by: jorturfer <jorge_turrado@hotmail.es> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com> * Improve documentation Co-authored-by: Zbynek Roubalik <zroubali@redhat.com> Signed-off-by: jorturfer <jorge_turrado@hotmail.es> * Remove whitespaces Signed-off-by: jorturfer <jorge_turrado@hotmail.es> * Clarify possible values to useRegex Signed-off-by: jorturfer <jorge_turrado@hotmail.es> * Update documentation to allow regex + messageRate Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com> Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com> Co-authored-by: Zbynek Roubalik <zroubali@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Was trying to figure out why I didn't hit this bug before when pinned to 1.0.0 and realized the 1.0.0 image was updated last night. I suspect it's actually grabbing a mirror of master - which it shouldn't do. 1.0.0 should remain a snapshot of the code as of whenvever last Tuesday was. New releases should automatically update master. And then we manually add
1.0.1or1.1.0or whatever.// cc @ahmelsayed @anirudhgarg @SatishRanjan
Related to #487
The text was updated successfully, but these errors were encountered: