Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ScaledObject webhook #5397

Closed
zroubalik opened this issue Jan 18, 2024 · 1 comment · Fixed by #5403
Closed

Refactor ScaledObject webhook #5397

zroubalik opened this issue Jan 18, 2024 · 1 comment · Fixed by #5403
Assignees
@wozniakjan
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@zroubalik
Copy link
Member

Proposal

Minor refactoring, see details in #5377 (comment)

Use-Case

No response

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response
@zroubalik zroubalik added needs-discussion feature-request All issues for new features that have not been committed to labels Jan 18, 2024
@zroubalik zroubalik mentioned this issue Jan 18, 2024
Merged
6 tasks
@wozniakjan
Copy link
Member

I will have the PR ready as soon as #5377 closes, keeping the changes locally for now and will rebase right after the merge :)

@zroubalik zroubalik moved this from To Triage to To Do in Roadmap - KEDA Core Jan 18, 2024
wozniakjan added a commit to wozniakjan/keda that referenced this issue Jan 18, 2024
@wozniakjan
chore: minor refactor to reduce copy/paste code in ScaledObject webhook
004f5d7 
closes: kedacore#5397

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan mentioned this issue Jan 18, 2024
Merged
3 tasks
wozniakjan added a commit to wozniakjan/keda that referenced this issue Jan 18, 2024
@wozniakjan
chore: minor refactor to reduce copy/paste code in ScaledObject webhook
1d6172a 
closes: kedacore#5397

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
wozniakjan added a commit to wozniakjan/keda that referenced this issue Jan 21, 2024
@wozniakjan
chore: minor refactor to reduce copy/paste code in ScaledObject webhook
4f8797c 
closes: kedacore#5397

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@github-project-automation github-project-automation bot moved this from To Do to Ready To Ship in Roadmap - KEDA Core Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wozniakjan wozniakjan

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: minor refactor to reduce copy/paste code in ScaledObject webhook wozniakjan/keda
2 participants
@zroubalik @wozniakjan