Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect validation of fallback if the metric type is not explicitly configured #6066

Closed
salvacorts opened this issue Aug 12, 2024 · 3 comments
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity

Comments

@salvacorts
Copy link

salvacorts commented Aug 12, 2024

Report

The fallback mechanism should only work if the metric type is AverageValue, which is the default (according to the docs).

If you do not explicitly declare the metric type, KEDA prints the following error:

2024-08-02T15:01:04Z	ERROR	scaledobject-validation-webhook	validation error	{"name": "foo", "error": "MetricType=, but Fallback can only be enabled for triggers with metric of type AverageValue"}****

Expected Behavior

KEDA should interpret an empty metricType as the default AverageValue.

Actual Behavior

KEDA prints an error

Steps to Reproduce the Problem

  1. Create a ScaledObject with fallback enabled (but without explicitly declaring the metricType of the scaler)
  2. Error is printed

Logs from KEDA operator

2024-08-02T15:01:04Z	ERROR	scaledobject-validation-webhook	validation error	{"name": "foo", "error": "MetricType=, but Fallback can only be enabled for triggers with metric of type AverageValue"}

KEDA Version

2.14.1

Kubernetes Version

None

Platform

Any

Scaler Details

No response

Anything else?

No response

@salvacorts salvacorts added the bug Something isn't working label Aug 12, 2024
@salvacorts
Copy link
Author

x-ref: #6065

Copy link

stale bot commented Oct 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 19, 2024
Copy link

stale bot commented Oct 29, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Oct 29, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity
Projects
Status: Ready To Ship
Development

No branches or pull requests

1 participant