fix: Do not disable fallback if the metric type is not explicitly configured #6065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fallback mechanism should only work if the metric type is
AverageValue
, which is the default (according to the docs).Problem is, if you do not explicitly declare the metric type, KEDA prints the following error and disables the fallback mechanism:
This PR fixes this by checking if the metric type is empty, in which case it's evaluated as
AverageValue
.Checklist
Fixes #
Relates to #