Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank vhost for Rabbitmq Scaler apiHost is erroring out when making api calls #790

Closed
mpduarte opened this issue Apr 29, 2020 · 5 comments · Fixed by #791
Closed

Blank vhost for Rabbitmq Scaler apiHost is erroring out when making api calls #790

mpduarte opened this issue Apr 29, 2020 · 5 comments · Fixed by #791
Labels
bug Something isn't working
Milestone

Comments

@mpduarte
Copy link

Blank vhost for Rabbitmq Scaler apiHost is erroring out when making api calls to the queue.

Expected Behavior

With no vhost specified the api call to RabbitMQ should look like this:
http://guest:guest@rabbitmq:15672/api/queues/%2F/queuename

Actual Behavior

With no vhost specified the api call to RabbitMQ looks like this:
http://guest:guest@rabbitmq:15672/api/queues/api//queuename

Debug log from Controller:
{"level":"debug","ts":"2020-04-29T00:15:39.676Z","logger":"scalehandler","msg":"Error getting scale decision","ScaledObject.Namespace":"cust0-herald-test","ScaledObject.Name":"celery-scaledobject","ScaledObject.ScaleType":"deployment","Error":"error inspecting rabbitMQ: error requesting rabbitMQ API status: 404 Not Found, response: {"error":"Object Not Found","reason":"Not Found"}, from: http://guest:guest@rabbitmq.cust0-herald-test.svc.cluster.local:15672/api/queues/api//celery"}

Steps to Reproduce the Problem

  1. Don't specify a vhost in the apiHost setting
  2. Deploy scaledobject without vhost specified

Specifications

  • KEDA Version: v1.4.1
  • Kubernetes Version: v1.14.8
  • Scaler(s): RabbitMQ
@mpduarte mpduarte added the bug Something isn't working label Apr 29, 2020
@tomkerkhove
Copy link
Member

So you're saying that the fix for #768 is not working out?

@zroubalik
Copy link
Member

@tbickford @holyketzer seems like RabitMQ scaler needs more love 😄

@holyketzer
Copy link
Contributor

holyketzer commented Apr 29, 2020

@mpduarte which value you provide in apiHost ?

  1. http://guest:guest@rabbitmq:15672/
  2. http://guest:guest@rabbitmq:15672//
  3. http://guest:guest@rabbitmq:15672/%2F

They all should work.

One case I'm not sure is http://guest:guest@rabbitmq:15672, let me check

@holyketzer
Copy link
Contributor

holyketzer commented Apr 29, 2020

Yes case without trailing slash wasn't covered. @mpduarte you can just add a trailing slash to your apiHost

@mpduarte
Copy link
Author

I had a trailing slash, the issue is I had is I specified /api/ at the end, for some reason I thought it was required, once I removed it, everything started working great. appreciate the quick responses!

@tomkerkhove tomkerkhove added this to the v1.5 milestone Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants