Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support AAD Pod Identity authentication for azure event hubs #994

Closed
1 task
tdesmet opened this issue Aug 13, 2020 · 6 comments
Closed
1 task

support AAD Pod Identity authentication for azure event hubs #994

tdesmet opened this issue Aug 13, 2020 · 6 comments
Labels
auth feature All issues for new features that have been committed to good first issue Good for newcomers Hacktoberfest scaler-azure-event-hubs

Comments

@tdesmet
Copy link

tdesmet commented Aug 13, 2020

Blob storage, service bus and storage queue triggers have support for AAD Pod identity authentication. It would be nice to also have this for azure event hubs so we can configure authentication the same way.

Specification

  • support AAD Pod Identity for authentication on azure event hubs trigger
@tdesmet tdesmet added feature-request All issues for new features that have not been committed to needs-discussion labels Aug 13, 2020
@tomkerkhove tomkerkhove added auth scaler-azure-event-hubs feature All issues for new features that have been committed to and removed feature-request All issues for new features that have not been committed to needs-discussion labels Aug 13, 2020
@jeffhollan
Copy link
Member

Adding a note here for any coming at it from a good first issue. I expect what would be required here is:

@eashi
Copy link
Contributor

eashi commented Oct 9, 2020

Anyone working on this one? Maybe I can pick it up if not.

@zroubalik
Copy link
Member

@eashi I am not aware of that. That would be really awesome if tou could contribute this 🎉

@eashi
Copy link
Contributor

eashi commented Oct 19, 2020

On which branch should I do this this btw? I have been working on master, but I haven't gone too deep yet and I can back track if necessary.
Edit: I believe I was doing the wrong thing working on master, I believe it will only take bug fixes for now, right?

@zroubalik
Copy link
Member

@eashi v2 please 🙂

@eashi
Copy link
Contributor

eashi commented Nov 22, 2020

This is done in PR 1306.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth feature All issues for new features that have been committed to good first issue Good for newcomers Hacktoberfest scaler-azure-event-hubs
Projects
None yet
Development

No branches or pull requests

5 participants