Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Kafka: split metadata and config for SASL and TLS #1074

Merged
merged 4 commits into from
Sep 10, 2020
Merged

[v2] Kafka: split metadata and config for SASL and TLS #1074

merged 4 commits into from
Sep 10, 2020

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Sep 3, 2020 •
edited
Loading

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

Splitting Kafka Auth mode to a separate sections for SASL and TLS. This is IMHO more convenient.

Checklist

Fixes #1043

@zroubalik zroubalik added this to the v2.0 milestone Sep 3, 2020
@zroubalik zroubalik changed the title Kafka: split metadata and config for SASL and TLS [v2] Kafka: split metadata and config for SASL and TLS Sep 3, 2020
@zroubalik
Copy link
Member Author

@ppatierno @grassiale @balchua PTAL

ppatierno
ppatierno reviewed Sep 4, 2020
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
pkg/scalers/kafka_scaler.go Show resolved Hide resolved
@ansonauhk ansonauhk mentioned this pull request Sep 6, 2020
Closed
4 tasks
@ahmelsayed
Copy link
Contributor

Thanks @zroubalik. I wasn't aware of SASL and thought initially that it's something specific to Kafka. But after figuring that out, this change makes a lot more sense.

There is a conflict in the CHANGELOG.md, but other than that it looks good!

Zbynek Roubalik added 4 commits September 10, 2020 10:11
Kafka: split metadata and config for SASL and TLS
48c8769 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Kafka: split metadata and config for SASL and TLS
8887a07 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
don't use enableSASL
094de63 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
fix changelog
fadcf70 
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik merged commit 05e8a9f into kedacore:v2 Sep 10, 2020
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
@yardenshoham @tomkerkhove
Deprecate explicitly setting metricName for all scalers (kedacore#1074
de587dc 
)

Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppatierno ppatierno ppatierno left review comments

@ahmelsayed ahmelsayed ahmelsayed approved these changes

Assignees

@ahmelsayed ahmelsayed

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Kafka Scaler with both SASL and SSL(TLS)
3 participants
@zroubalik @ahmelsayed @ppatierno