Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For scaling deployments in particular, use a direct object get rather than the /scale API #1458

Merged
merged 7 commits into from
Jan 6, 2021
Merged

For scaling deployments in particular, use a direct object get rather than the /scale API #1458

merged 7 commits into from
Jan 6, 2021

Commits on Dec 28, 2020

  1. For scaling deployments in particular, use a direct object get rather… 

    … than the /scale API so that it can use the informer cache for better performance.

This is annoying as a special case but is so common and improves performance so much that I think it's worthwhile to include. Another option would be to majorly increase the QPS rate limit on the scaling API client however that would also increase kube-apiserver load while watches/informers are generally much less impactful.

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    4754f04 View commit details
    Browse the repository at this point in the history

  2. Update changelog. 

    Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    2288c7e View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2021

  1. Merge branch 'main' into less-scale-get

    @coderanger
    coderanger committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    84d3698 View commit details
    Browse the repository at this point in the history

  2. Use the already-normalized GVKR data so less weird string parsing. 

    Also adds support for StatefulSets for symmetry.

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    4eb4cb0 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    abcf8bb View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>

Signed-off-by: Noah Kantrowitz <noah@coderanger.net>
    @coderanger
    coderanger committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    ff66687 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into less-scale-get

    @coderanger
    coderanger committed Jan 6, 2021
    Configuration menu
    Copy the full SHA
    8e0a225 View commit details
    Browse the repository at this point in the history