Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: optimize getLagForPartition #1464

Merged
merged 2 commits into from
Jan 4, 2021
Merged

kafka: optimize getLagForPartition #1464

merged 2 commits into from
Jan 4, 2021

Conversation

messense
Copy link
Contributor

@messense messense commented Dec 30, 2020

Optimize kafka scaler getLagForPartition function to reduce a GetOffset call when consumer offset is invalid and offset reset policy is latest.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Changelog has been updated

Signed-off-by: messense <messense@icloud.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit 2db20b0 into kedacore:main Jan 4, 2021
@messense messense deleted the optimize-kafka branch January 4, 2021 13:20
ycabrer pushed a commit to ycabrer/keda that referenced this pull request Mar 1, 2021
Signed-off-by: messense <messense@icloud.com>

Co-authored-by: Zbynek Roubalik <726523+zroubalik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants