Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show min/max replica count when using kubectl get scaledobject #1534

Merged
merged 5 commits into from
Jan 26, 2021
Merged

Show min/max replica count when using kubectl get scaledobject #1534

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b1a9ad
Show min/max replica count when using kubectl get scaledobject
Ritikaa96 Jan 25, 2021
5553e6d
addressing the comments to show min/max replica counts when using kub…
Ritikaa96 Jan 25, 2021
e0c3bcc
shuffling min/max in scaledobject, adding min/max replicacount when u…
Ritikaa96 Jan 26, 2021
126457a
CHANGELOG: Show MIN/MAX replica counts when using kubectl get scaledo…
Ritikaa96 Jan 26, 2021
af6d787
Changelog correction: Show MIN/MAX replica counts when using kubectl …
Ritikaa96 Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/v1alpha1/scaledobject_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import (
// +kubebuilder:printcolumn:name="ScaleTargetKind",type="string",JSONPath=".status.scaleTargetKind"
// +kubebuilder:printcolumn:name="ScaleTargetName",type="string",JSONPath=".spec.scaleTargetRef.name"
// +kubebuilder:printcolumn:name="Triggers",type="string",JSONPath=".spec.triggers[*].type"
// +kubebuilder:printcolumn:name="Min Replicas",type="integer",JSONPath=".spec.minReplicaCount"
zroubalik marked this conversation as resolved.
Show resolved Hide resolved
// +kubebuilder:printcolumn:name="Max Replicas",type="integer",JSONPath=".spec.maxReplicaCount"
// +kubebuilder:printcolumn:name="Authentication",type="string",JSONPath=".spec.triggers[*].authenticationRef.name"
// +kubebuilder:printcolumn:name="Ready",type="string",JSONPath=".status.conditions[?(@.type==\"Ready\")].status"
// +kubebuilder:printcolumn:name="Active",type="string",JSONPath=".status.conditions[?(@.type==\"Active\")].status"
Expand Down
6 changes: 6 additions & 0 deletions config/crd/bases/keda.sh_scaledobjects.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@ spec:
- jsonPath: .spec.triggers[*].type
name: Triggers
type: string
- jsonPath: .spec.minReplicaCount
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to update our Helm chart as well; taking mental note

name: MinReplicas
type: integer
- jsonPath: .spec.maxReplicaCount
name: MaxReplicas
type: integer
- jsonPath: .spec.triggers[*].authenticationRef.name
name: Authentication
type: string
Expand Down