Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed MIN field for scaledjob. #1553

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Removed MIN field for scaledjob. #1553

merged 2 commits into from
Feb 2, 2021

Conversation

Shubham82
Copy link
Contributor

@Shubham82 Shubham82 commented Feb 1, 2021 •
edited by tomkerkhove
Loading

Signed-off-by: Shubham Kuchhal shubham.kuchhal@india.nec.com

Removed MIN field from kubectl get scaledjobor kubectl get sj

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • Tests have been added
  • A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
  • Changelog has been updated

Fixes #1552

@Shubham82
Remome MIN field for scaledjob.
3cd5e85 
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
@Shubham82
Copy link
Contributor Author

Hi @zroubalik @ahmelsayed @tomkerkhove
Could you please take a look.
Thanks.

@Shubham82 Shubham82 mentioned this pull request Feb 1, 2021
Closed
@tomkerkhove
Copy link
Member

Hi @zroubalik @ahmelsayed @tomkerkhove
Could you please take a look.
Thanks.

No it's ok, we sync the generated CRDs during releases - Thanks for checking!

@tomkerkhove
Copy link
Member

Can you update the changelog please?

@Shubham82
Copy link
Contributor Author

Shubham82 commented Feb 2, 2021 •
edited
Loading

Thanks @tomkerkhove. Sure, i will update the changelog.

@Shubham82
Copy link
Contributor Author

No it's ok, we sync the generated CRDs during releases - Thanks for checking!

@tomkerkhove May this reply is for the query i asked in the issue here

@Shubham82
Updated the CHANGELOG.
f4e82a5 
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
@Shubham82
Copy link
Contributor Author

Can you update the changelog please?

Addressed the comment.

@tomkerkhove tomkerkhove merged commit bf8d822 into kedacore:main Feb 2, 2021
ycabrer pushed a commit to ycabrer/keda that referenced this pull request Mar 1, 2021
@Shubham82 @ycabrer
Removed MIN field for scaledjob. (kedacore#1553)
1d53f65
Rodolfodc pushed a commit to sidilabs/keda that referenced this pull request Mar 11, 2021
@Shubham82 @Rodolfodc
Removed MIN field for scaledjob. (kedacore#1553)
91a0173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MIN field from kubectl get scaledjob.
2 participants
@Shubham82 @tomkerkhove