-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RabbitMQ publishRate
trigger
#1653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
rwkarg
added a commit
to rwkarg/keda-docs
that referenced
this pull request
Mar 3, 2021
Corresponding code change: kedacore/keda#1653
Signed-off-by: Karg <rkarg@blizzard.com>
ahmelsayed
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rwkarg
Signed-off-by: Karg <rkarg@blizzard.com>
Signed-off-by: Karg <rkarg@blizzard.com>
zroubalik
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rwkarg !
Let's merge this once docs PR is finalized. |
Thanks a ton @rwkarg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Karg rwkarg@gmail.com
Added an additional trigger for RabbitMQ scaling on
publishRate
.This allows for higher throughput workloads to scale based on the incoming message rate. This is useful because the message backlog does not often correlate with the desired instance count.
Both
publishRate
andqueueLength
triggers can be specified on a single ScaledObject. I would imagine the normal case would be to use both of these triggers.Checklist
[ ] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)publishRate
trigger keda-docs#388Fixes #1643