Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding HTTP timeout to the IBM MQ Scaler #1758

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Conversation

arschles
Copy link
Contributor

@arschles arschles commented Apr 27, 2021

Following #1133 and the related PR #1251, this PR adds a timeout to the HTTP client used by the IBM MQ scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified) N/A
  • A PR is opened to update the documentation on (repo) (if applicable) N/A
  • Changelog has been updated

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles arschles marked this pull request as ready for review April 27, 2021 21:42
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arschles !

@zroubalik zroubalik merged commit c7e25fa into kedacore:main Apr 28, 2021
@arschles arschles deleted the http-client branch April 28, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants