Show HashiCorp Vault Address when using 'kubectl get ta' or 'kubectl get cta' #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cta Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
Shubham82
changed the title
Kubectl get ta or kubectl get cta
Shubham82
changed the title
|
Hi @tomkerkhove @zroubalik |
zroubalik
reviewed
Jun 4, 2021
|
And please update changelog as well :) |
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
Addressed the comment |
Sure I will soon create a PR for it also. |
Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com>
1 task
Done! kedacore/charts#164 |
nilayasiktoprak
pushed a commit
to nilayasiktoprak/keda
that referenced
this pull request
Oct 23, 2021
…get cta' (kedacore#1862) Signed-off-by: Shubham Kuchhal <shubham.kuchhal@india.nec.com> Signed-off-by: nilayasiktoprak <nilayasiktoprak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Kuchhal shubham.kuchhal@india.nec.com
Add
VaultAdressfield in TriggerAuthentication and ClusterTriggerAuthentication CRD so on usingkubectl get TriggerAuthenticationorkubectl get ClusterTriggerAuthenticationit would show the Address of HashiCorp Vault.Checklist
Fixes #1826